Recognize image/jpg
as MimeType::Jpeg
#41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch, when MIME type is
image/jpg
, Lofty will recognize it asMimeType::Jpeg
too, instead of falling back toUnknown
.I tested this patch with Amberol (Which uses MimeType:: enums to decide whether to show album arts) and now it displays JPG album arts just fine.
In my opinion, I don't see a reason for creating a
MimeType::Jpg
enum, since actually JPG and JPEG are the same thing but with a different extension.