Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize image/jpg as MimeType::Jpeg #41

Merged
merged 1 commit into from Apr 27, 2022

Conversation

alissonlauffer
Copy link
Contributor

With this patch, when MIME type is image/jpg, Lofty will recognize it as MimeType::Jpeg too, instead of falling back to Unknown.

I tested this patch with Amberol (Which uses MimeType:: enums to decide whether to show album arts) and now it displays JPG album arts just fine.

In my opinion, I don't see a reason for creating a MimeType::Jpg enum, since actually JPG and JPEG are the same thing but with a different extension.

@Serial-ATA
Copy link
Owner

Thanks!

@Serial-ATA Serial-ATA merged commit 71f99f9 into Serial-ATA:main Apr 27, 2022
@alissonlauffer alissonlauffer deleted the jpg-as-jpeg branch April 27, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants