Stop passing a function to store.dipatch and stop effect e.g. pipe(ma…

…p(...)) that is returns a function ngrx#1906

modules/effects/src/effects_runner.ts

@@ -3,6 +3,8 @@ import { Store } from '@ngrx/store';
 import { Subscription } from 'rxjs';
 
 import { EffectSources } from './effect_sources';
+import { tap } from 'rxjs/operators';
+import { throwErrorOnInvalidAction } from '../../../modules/store/src/actions_subject';
 
 @Injectable()
 export class EffectsRunner implements OnDestroy {
@@ -17,6 +19,7 @@ export class EffectsRunner implements OnDestroy {
     if (!this.effectsSubscription) {
       this.effectsSubscription = this.effectSources
         .toActions()
+        .pipe(tap(action => throwErrorOnInvalidAction(action)))
         .subscribe(this.store);
     }
   }

modules/store/src/actions_subject.ts

@@ -5,6 +5,18 @@ import { Action } from './models';
 
 export const INIT = '@ngrx/store/init' as '@ngrx/store/init';
 
+export const throwErrorOnInvalidAction = (action: Action) => {
+  if (typeof action === 'undefined') {
+    throw new TypeError(`Actions must be objects`);
+  } else if (typeof action === 'function') {
+    throw new TypeError(`
+      Actions as function are not now allowed.
+      Make sure your action is called e.g someAction()`);
+  } else if (typeof action.type === 'undefined') {
+    throw new TypeError(`Actions must have a type property`);
+  }
+};
+
 @Injectable()
 export class ActionsSubject extends BehaviorSubject<Action>
   implements OnDestroy {
@@ -13,12 +25,7 @@ export class ActionsSubject extends BehaviorSubject<Action>
   }
 
   next(action: Action): void {
-    if (typeof action === 'undefined') {
-      throw new TypeError(`Actions must be objects`);
-    } else if (typeof action.type === 'undefined') {
-      throw new TypeError(`Actions must have a type property`);
-    }
-
+    throwErrorOnInvalidAction(action);
     super.next(action);
   }