fix: remove empty fields from query param and update regex creation u…

…nit test
ServeRest · Jan 22, 2024 · 00d44a1 · 00d44a1
1 parent ca33b37
commit 00d44a1
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/utils/alterarValoresParaRegex.js b/src/utils/alterarValoresParaRegex.js
@@ -6,7 +6,11 @@ const permittedKeys = ['nome', 'password', 'descricao']
 
 module.exports = queryString => {
   Object.keys(queryString).forEach(key => {
-    if (permittedKeys.includes(key) && queryString[key] != null) {
+    const isFieldEmpty = !queryString[key]
+    /* istanbul ignore next */
+    if (isFieldEmpty) {
+      delete queryString[key]
+    } else if (permittedKeys.includes(key)) {
       try {
         // Add 'i' flag for case-insensitive matching
         queryString[key] = new RegExp(escapeStringRegexp(queryString[key]), 'i')

diff --git a/test/unit/alterarValoresParaRegex.test.js b/test/unit/alterarValoresParaRegex.test.js
@@ -12,7 +12,6 @@ describe('alterarValoresParaRegex', () => {
     }
 
     const result = alterarValoresParaRegex(queryString)
-    console.log(result)
 
     expect(result.nome).to.be.instanceOf(RegExp)
     expect(result.password).to.be.instanceOf(RegExp)
@@ -34,4 +33,16 @@ describe('alterarValoresParaRegex', () => {
     expect(result.password.toString()).to.equal('/12\\*34/i')
     expect(result.descricao.toString()).to.equal('/des\\|cription/i')
   })
+
+  it('should remove field without value', () => {
+    const queryString = {
+      nome: 'test',
+      password: '',
+      empty: ''
+    }
+
+    const result = alterarValoresParaRegex(queryString)
+
+    expect(result).to.be.deep.equal({ nome: /test/i })
+  })
 })