Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new fields in config page #282

Merged
merged 33 commits into from
Jan 5, 2023
Merged

Conversation

nandhinibsn
Copy link
Contributor

@nandhinibsn nandhinibsn commented Oct 25, 2022

Resolve #

Description:

This is the feature to enable next important fields in the configuration settings page for the user to modify and see the changes made in the UI.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@nandhinibsn
Copy link
Contributor Author

Recent screenshot of the config page:
image
image

@nandhinibsn
Copy link
Contributor Author

config page with extra fields:
image
image

@nandhinibsn
Copy link
Contributor Author

nandhinibsn commented Nov 7, 2022

Hey, @JosephMarinier and @gabegma, To disable the postprocessors, the type should allow null to go through the patch req. Right now, the postprocessors type allows only these (Partial<components["schemas"]["TemperatureScaling"]> &
Partial<components["schemas"]["ThresholdConfig"]> &
Partial<components["schemas"]["CustomObject"]>)[]. So, is there a change required on the backend side?

@nandhinibsn
Copy link
Contributor Author

Screenshot of the latest work after adding design review comments: Please let me know your feedback @gabegma @JosephMarinier
image
image
image
image

@nandhinibsn
Copy link
Contributor Author

nandhinibsn commented Dec 9, 2022

@gabegma ,Can you please provide the information for the below items:

  1. description text for the tabs here
  2. stepper values of min, max and how much step can go on increment/decrementing the number https://github.com/ServiceNow/azimuth/blob/nandhini/expandConfigPage/webapp/src/pages/Settings.tsx#L23

@JosephMarinier
Copy link
Contributor

Can you log the change in CHANGELOG.md and check the checklist in the PR description?

@nandhinibsn
Copy link
Contributor Author

nandhinibsn commented Dec 15, 2022

Can you log the change in CHANGELOG.md and check the checklist in the PR description?

Can you please help me with adding the issue/resolve id for this feature?

@JosephMarinier
Copy link
Contributor

JosephMarinier commented Dec 15, 2022

Can you log the change in CHANGELOG.md and check the checklist in the PR description?

Can you please help me with adding the issue/resolve id for this feature?

There was no GitHub issue created for this feature.

If a box does not apply, check it to acknowledge it.

webapp/src/pages/Settings.tsx Outdated Show resolved Hide resolved
webapp/src/pages/Settings.tsx Outdated Show resolved Hide resolved
webapp/src/pages/Settings.tsx Outdated Show resolved Hide resolved
webapp/src/pages/Settings.tsx Outdated Show resolved Hide resolved
JosephMarinier and others added 4 commits December 19, 2022 15:23
- Fix incomplete documentation links
- Make text fields font size uniform
- Reorder imports and API types alphabetically
- Avoid unnecessary indent
when resizing the page or when the warning appears.
Co-authored-by: Gabrielle Gauthier Melancon <gabrielle.gm@servicenow.com>
- Reduce from 43 to 17 (60 %) the number of places we specify dimensions (`width`, `height`, `margin`, `padding`, `gap`, etc.).
- Use `display="grid"` in multiple places to get the desired alignment.
- Use `Checkbox`es with a `FormControlLabel`.
@JosephMarinier JosephMarinier enabled auto-merge (squash) January 5, 2023 03:25
@JosephMarinier JosephMarinier enabled auto-merge (squash) January 5, 2023 03:29
@JosephMarinier JosephMarinier enabled auto-merge (squash) January 5, 2023 03:31
@JosephMarinier JosephMarinier merged commit 00478e9 into main Jan 5, 2023
@JosephMarinier JosephMarinier deleted the nandhini/expandConfigPage branch January 5, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants