-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for persistent ID and filtering on ID in exploration space #301
Conversation
4e8e908
to
38de248
Compare
aced748
to
e78089e
Compare
Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
abbbe57
to
90393a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mentioned by
was not a great variable name... I agree. It's just a detail, but here is a simple change:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mentioned by
was not a great variable name... I agree! It's just a detail, but here is a simple change:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's pretty cool! Thank you!
It should then be very easy to add it to the response of /utterances
... In another PR?
Right @JosephMarinier, maybe it can be included in the PR where you show it on hover in the UI? That way you can name the variable in the API how you prefer. I can also include it in this PR, let me know. |
756bad6
to
11350cc
Compare
Perfect plan! 👌 |
Supports #297 and fixes #200
Description:
You can look at the commits' message for the details of what I have done.
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-files
at the end.our users.
README
files and our wiki for any big design decisions, if relevant.