Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #337

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Update README.md #337

merged 2 commits into from
Dec 9, 2022

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Dec 9, 2022 •
edited
Loading

Description:

Adding a few details for the EMNLP conference.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

JosephMarinier
JosephMarinier reviewed Dec 9, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
JosephMarinier
JosephMarinier approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@gabegma @JosephMarinier
Update README.md
eb3db06 
Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
@gabegma gabegma merged commit 6dc68c7 into main Dec 9, 2022
@gabegma gabegma deleted the update-readme branch December 9, 2022 17:02
JosephMarinier added a commit that referenced this pull request Dec 20, 2022
@gabegma @JosephMarinier
Update README.md (#337)
d94bf43 
* Update README.md

* Update README.md

Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>

Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosephMarinier JosephMarinier JosephMarinier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gabegma @JosephMarinier