Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save modules' metadata in cache #352

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Save modules' metadata in cache #352

merged 2 commits into from
Jan 6, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Dec 23, 2022

Resolve #344

Description:

  • I'm not sure if meta-data is the best name for both the config attributes affecting the modules, and the module options. LMK if you prefer another term.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma changed the title Ggm/improve caching Save modules' metadata in cache Dec 23, 2022
@gabegma gabegma force-pushed the ggm/improve-caching branch 2 times, most recently from 4140c1c to 27fffd3 Compare January 3, 2023 20:44
@gabegma gabegma marked this pull request as ready for review January 4, 2023 00:12
.gitignore Outdated Show resolved Hide resolved
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! 🎩👌

@gabegma gabegma enabled auto-merge (squash) January 6, 2023 20:37
@gabegma gabegma merged commit 4dd88aa into main Jan 6, 2023
@gabegma gabegma deleted the ggm/improve-caching branch January 6, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save caching metadata for every module for debugging purposes
2 participants