Add units to config fields #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gabegma, Please confirm if these are the expected fields to have the units displayed and also, please share the units for each one. Thanks! |
nandhinibsn
force-pushed
the
ConfigPage/AddUnits
branch
from
a5b1cf5
to
48828cc
Compare
nandhinibsn
force-pushed
the
ConfigPage/AddUnits
branch
from
e4e8415
to
6168392
Compare
* One configuration object to rule them all * Create a `NumberField` component * Move utility functions outside `Settings` as much as possible to avoid unnecessarily redefining them on every render. * Add temperature to CLINC Dummy multi pipelines
Merged
HTML considers input values outside of the `step` to be invalid and automatically adds a basic tooltip. In our context, we don't think it's an error, so let's hide the basic tooltip.
JosephMarinier
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #
Description:
Added units to the following config sub fields:
Dataset warnings:
max_delta_class_imbalance
max_delta_mean_tokens
max_delta_representation
max_delta_std_tokens
min_num_per_class
Syntax
short_sentence_max_token
long_sentence_min_token
Similarity:
conflicting_neighbors_threshold
no_close_threshold
Uncertainty:
iterations
high_epistemic_threshold
Postprocesors:
temperature
threshold
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-filesat the end.our users.
READMEfiles and our wiki for any big design decisions, if relevant.