Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce mypy in pre-commit #392

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Enforce mypy in pre-commit #392

merged 2 commits into from
Jan 25, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Jan 25, 2023

Description:

mypy was never enforced in the pre-commit because, at a certain time, we couldn't put the errors to 0 easily. This is no longer the case, and I don't think we should be able to commit with mypy errors.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma self-assigned this Jan 25, 2023
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Very good catch! Thank you!
I just have a small comment to clean it up a bit.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
@gabegma gabegma enabled auto-merge (squash) January 25, 2023 16:38
@gabegma gabegma merged commit 00356df into main Jan 25, 2023
@gabegma gabegma deleted the ggm/inforce-mypy branch January 25, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants