Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor flaky test #417

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Refactor flaky test #417

merged 2 commits into from
Feb 6, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Feb 1, 2023

Description:

  • This test sometimes fails, and I don't understand why. I cleaned it up, but I'm not sure if my code is equivalent and could improve anything. Opening this PR to brainstorm. Any ides @JosephMarinier @Dref360 ?
    Screen Shot 2023-01-31 at 5 48 19 PM

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma changed the title Fix flaky test Refactor flaky test Feb 6, 2023
@gabegma gabegma marked this pull request as ready for review February 6, 2023 15:11
@gabegma gabegma self-assigned this Feb 6, 2023
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you said, I'm not sure we solved the problem, but we made the code easier to understand and with the added assertion print we should be able to understand the error next time it happens. 👍

@gabegma gabegma merged commit 964cbe4 into main Feb 6, 2023
@gabegma gabegma deleted the ggm/fix-test-that-sometimes-fails branch February 6, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants