Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt route to add proposed actions #429

Merged
merged 7 commits into from
Feb 13, 2023
Merged

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Feb 9, 2023

Part of #297

Description:

  • New route to import proposed actions

Remaining

  • Adapt call to update tags in the front end.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma self-assigned this Feb 9, 2023
@gabegma gabegma force-pushed the ggm/import-proposed-actions branch 2 times, most recently from d8a0d68 to 3e2a77a Compare February 9, 2023 21:44
@JosephMarinier JosephMarinier marked this pull request as ready for review February 11, 2023 14:30
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very good! So satisfying! Thank you!
I only have comments on variable names, from a second pair of (fresh) eyes.

gabegma and others added 2 commits February 13, 2023 13:29
Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
@gabegma
Copy link
Contributor Author

gabegma commented Feb 13, 2023

Should the front-end be reviewed before merging @JosephMarinier?

@JosephMarinier
Copy link
Contributor

I think the front end is fine. It was very straightforward.

Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can give camelCase to the API. That's what the front end does. Two changes...

tests/test_routers/test_utterances.py Outdated Show resolved Hide resolved
tests/test_routers/test_utterances.py Outdated Show resolved Hide resolved
@gabegma gabegma enabled auto-merge (squash) February 13, 2023 19:24
@gabegma gabegma enabled auto-merge (squash) February 13, 2023 19:24
@gabegma gabegma changed the title Import proposed actions Adapt route to add proposed actions Feb 13, 2023
@gabegma gabegma merged commit 8af558f into main Feb 13, 2023
@gabegma gabegma deleted the ggm/import-proposed-actions branch February 13, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants