-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt route to add proposed actions #429
Conversation
d8a0d68
to
3e2a77a
Compare
3e2a77a
to
3af232d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very very good! So satisfying! Thank you!
I only have comments on variable names, from a second pair of (fresh) eyes.
Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
Should the front-end be reviewed before merging @JosephMarinier? |
I think the front end is fine. It was very straightforward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can give camelCase to the API. That's what the front end does. Two changes...
777a37c
to
1e64370
Compare
Part of #297
Description:
Remaining
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-files
at the end.our users.
README
files and our wiki for any big design decisions, if relevant.