Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export utterances, export proposed actions to utterance table #445

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

nandhinibsn
Copy link
Contributor

@nandhinibsn nandhinibsn commented Feb 16, 2023

Part of #297

Description:

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@nandhinibsn nandhinibsn force-pushed the nandhini/export-utterances-proposed-actions branch from b270c34 to ee4631f Compare February 22, 2023 15:05
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good practice to "tie" the button and the menu together, using aria-controls and id, for accessibility reasons. With that, it should be good to go!

@nandhinibsn nandhinibsn force-pushed the nandhini/export-utterances-proposed-actions branch from ee4631f to 54ad90f Compare February 22, 2023 16:59
@nandhinibsn
Copy link
Contributor Author

Thank you @JosephMarinier for taking up your time in reviewing and suggesting some valuable inputs :)

@nandhinibsn nandhinibsn merged commit c668bd4 into main Feb 22, 2023
@nandhinibsn nandhinibsn deleted the nandhini/export-utterances-proposed-actions branch February 22, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants