Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up pipeline vs model and previous PR #450

Merged
merged 4 commits into from
Feb 27, 2023
Merged

Clean up pipeline vs model and previous PR #450

merged 4 commits into from
Feb 27, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Feb 17, 2023

Description:

  • Cleanup following the previous PRs.
  • For model vs pipeline, I tried to remain as coherent as possible. I refer model as the callable function in PipelineDefinition, even though this model can be a HF pipeline, a model, a custom pipeline, or a file prediction reader.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@@ -28,10 +28,7 @@ def test_create_sentiment_pipeline(simple_text_config):
# By default, use L2 gradient calculation
assert task.gradient_calculation == GradientCalculation.L2

sa = task.get_model()

# As of Jan 6, 2021, fast tokenizers are not supported in pipelines
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer true, but the tokenizer still has is_fast=False in this case. I removed this line in the test since it wasn't testing something useful.

@gabegma gabegma self-assigned this Feb 17, 2023
@gabegma gabegma force-pushed the ggm/clean-up branch 2 times, most recently from 7f657c1 to ff6dae9 Compare February 27, 2023 21:19
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gabegma gabegma merged commit ab4f415 into main Feb 27, 2023
@gabegma gabegma deleted the ggm/clean-up branch February 27, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants