-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up pipeline vs model and previous PR #450
Conversation
@@ -28,10 +28,7 @@ def test_create_sentiment_pipeline(simple_text_config): | |||
# By default, use L2 gradient calculation | |||
assert task.gradient_calculation == GradientCalculation.L2 | |||
|
|||
sa = task.get_model() | |||
|
|||
# As of Jan 6, 2021, fast tokenizers are not supported in pipelines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer true, but the tokenizer still has is_fast=False
in this case. I removed this line in the test since it wasn't testing something useful.
Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
7f657c1
to
ff6dae9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description:
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-files
at the end.our users.
README
files and our wiki for any big design decisions, if relevant.