Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated types for Unions in Dicts #455

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

JosephMarinier
Copy link
Contributor

Description:

This is the same fix as the List items (which I am simplifying a little bit in this PR).

There isn't any Unions in Dicts for the moment, but I am working on something that adds some.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

There isn't any for the moment, but I am working on something that adds some.
@JosephMarinier JosephMarinier merged commit 4f013f6 into main Feb 17, 2023
@JosephMarinier JosephMarinier deleted the joseph/fix-generated-types-anyof branch February 17, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants