Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate dev dependencies to new poetry group #462

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

JosephMarinier
Copy link
Contributor

Description:

Migrate dev dependencies from [tool.poetry.dev-dependencies] to new [tool.poetry.group.dev.dependencies] introduced in Poetry 1.2.0.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma self-requested a review February 22, 2023 19:16
Copy link
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get Warning: poetry.lock is not consistent with pyproject.toml. You may be getting improper dependencies. Run poetry lock [--no-update] to fix it. Not you? I don't think that it is linked to your change, but could you update it regardless? Otherwise I can do it.

@JosephMarinier
Copy link
Contributor Author

Oh right! The poetry.lock is missing some stuff on main. I'll include it in this PR. Thanks!
Then, my change was affecting the content-hash.
Here is the diff: https://github.com/ServiceNow/azimuth/compare/2359f1c14194440d833db15f9f0c08d0885386a8..374076fa4ad469f641983078f736b2147fe40386

@gabegma
Copy link
Contributor

gabegma commented Feb 22, 2023

I updated the lock in #463. Thanks!

@JosephMarinier JosephMarinier enabled auto-merge (squash) February 22, 2023 21:01
@JosephMarinier JosephMarinier merged commit 29c4907 into main Feb 22, 2023
@JosephMarinier JosephMarinier deleted the joseph/migrate-dev-dependencies branch February 22, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants