-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fix to browser history after navigating to exploration page with no pipeline #464
Add fix to browser history after navigating to exploration page with no pipeline #464
Conversation
There was a console error which occurred when we navigate to the exploration page with no pipeline. I simplified the solution to navigating on the Dashboard page instead of the Exploration page. I believe it's more of a simplified way. Let me know your thoughts @JosephMarinier |
Hey @JosephMarinier, the solution added to Dashboard has been reverted as it resolved the issue with tracking history. Still, it did not switch tabs from prediction overview to utterance table if no pipeline was selected from the exploration page. Additionally, I understood why the console error was caused by reading this blog. To solve the bug, I added useEffect to handle the pipeline change from the exploration page to solve the issue with tracking history while the console error is not occurring anymore. Let me know what you think |
Excellent! 👍 |
Okay, Make sense. I will add the condition back to the Dashboard page. |
30ffb02
to
2e3952e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🇮🇹
Thank you for your time and valuable suggestion :) |
Resolve #
Description:
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-files
at the end.our users.
README
files and our wiki for any big design decisions, if relevant.