New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import proposed actions to utterance table #465

Merged

nandhinibsn merged 16 commits into main from nandhini/import-proposed-actions

Mar 8, 2023

Contributor

nandhinibsn commented Feb 24, 2023 •

edited by JosephMarinier

Loading

Resolve #297

Description:

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
PRE-COMMIT. You ran pre-commit on all commits, or else, you
ran pre-commit run --all-files at the end.
USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
our users.
DEV CHANGES.
- Update the documentation if this PR changes how to develop/launch on the app.
- Update the README files and our wiki for any big design decisions, if relevant.
- Add unit tests, docstrings, typing and comments for complex sections.

nandhinibsn requested a review from JosephMarinier

February 24, 2023 16:24

nandhinibsn self-assigned this

nandhinibsn force-pushed the nandhini/import-proposed-actions branch from 0cf9e07 to 6b94fbe Compare

February 24, 2023 22:27

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

Contributor

JosephMarinier left a comment

I don't think you need any slice() for that. Here are some suggestions...

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Show resolved Hide resolved

nandhinibsn force-pushed the nandhini/import-proposed-actions branch from 6b94fbe to ee61e3a Compare

February 28, 2023 02:47

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

nandhinibsn force-pushed the nandhini/import-proposed-actions branch 3 times, most recently from 6046f2c to f64113a Compare

March 3, 2023 23:05

JosephMarinier requested changes

View reviewed changes

Contributor

JosephMarinier left a comment •

edited

Loading

EDIT: I was confused by another change, this simplification wasn't right.
~~With the two following suggestions, I think you should be able to simply this bit:~~

webapp/src/services/api.ts Outdated Show resolved Hide resolved

webapp/src/services/api.ts Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/services/api.ts Outdated Show resolved Hide resolved

nandhinibsn force-pushed the nandhini/import-proposed-actions branch from f64113a to 44a67f1 Compare

March 6, 2023 19:28

JosephMarinier reviewed

View reviewed changes

webapp/src/services/api.ts Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/services/api.ts Outdated Show resolved Hide resolved

nandhinibsn added 11 commits

March 7, 2023 14:49


          Add import button

817f367


          Read, parse CSV data, update DataAction

79dabc5


          Code clean up - remove console log statements

23f8b07


          Code clean up, display modal if no records or headers in CSV

35a3a99


          Code review suggestions added and code simplified

d1ae39a


          Review comments - change dialog to toast, remove unused css, logic si…

0ffea91

…mplified, linear error display


          Add linear condition for error message scenarios

8ce580d


          Update dataAction to send array of utterancePatch

c5219e3


          Assert the order of CSV headers, Review comments to simplify the upda…

fdadd4f

…teDateAction


          Review comments - Assert headers, fix issue with mutation fetch

f9d2ab1


          Patch utterance dataaction if persistentId exist in utterance

a5835da

nandhinibsn force-pushed the nandhini/import-proposed-actions branch from af8ab28 to a5835da Compare

March 7, 2023 19:50

JosephMarinier reviewed

View reviewed changes

webapp/src/services/api.ts Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Utterance/UtteranceDataAction.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Outdated Show resolved Hide resolved

JosephMarinier reviewed

View reviewed changes

webapp/src/services/api.ts Outdated Show resolved Hide resolved

nandhinibsn and others added 4 commits

March 7, 2023 16:52


          Equality check, fileonload return, use trimEnd instead of slice last row

fd79737


          Add es-lint to skip warning for not using strict equality

2ebde76


          Ignore not found persistent ids

e1f38a1

in case the new dataset contains fewer samples, which would be expected for the proposed action `remove`.


          Add comment

db0c3b3

JosephMarinier reviewed

View reviewed changes

webapp/src/components/Analysis/UtterancesTable.tsx Show resolved Hide resolved


          Revert unnecessary change of blank line

2b2c5f0

JosephMarinier approved these changes

View reviewed changes

Contributor

JosephMarinier left a comment

Very cool feature! 👍

Contributor Author

nandhinibsn commented Mar 8, 2023

Very cool feature! 👍

I appreciate your patience in reviewing it and your input. :) Thank you.

nandhinibsn merged commit 5811d4d into main

nandhinibsn deleted the nandhini/import-proposed-actions branch

March 8, 2023 19:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment