Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up config vs task_manager.config #499

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Mar 17, 2023

Description:

  • Quick cleanup. When task_manager and config were both present in a function args, we would often arbitrarily use task_manager.config or config.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma self-assigned this Mar 17, 2023
@gabegma gabegma changed the title Cleanup config vs task_manager.config Clean up config vs task_manager.config Mar 17, 2023
@gabegma gabegma marked this pull request as ready for review March 17, 2023 19:16
Comment on lines -118 to -119
postprocessing_editable(task_manager.config, idx)
for idx in range(len(config.pipelines))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤮

Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, cool! 👍

@gabegma gabegma merged commit 1047681 into main Mar 21, 2023
@gabegma gabegma deleted the ggm/clean-up-task-manager-config branch March 21, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants