Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support serving the front end in HTTPS #507

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Support serving the front end in HTTPS #507

merged 2 commits into from
Mar 22, 2023

Conversation

JosephMarinier
Copy link
Contributor

@JosephMarinier JosephMarinier commented Mar 21, 2023

Description:

This will be an undocumented "beta" feature for now, until we use it a little bit and make sure it is useful in this state.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

in `docker-compose.yml` and have the front end call the back end using Docker Compose's internal network. So, when using Docker Compose (`make launch`), the back-end API will only be accessible through the front-end proxy (for example, the Swagger UI will be at http://localhost:8080/api/local/docs). This way, if you use HTTPS to secure the front end (by setting env vars `HTTPS_KEY` and `HTTPS_CERT`), the back end will be secured too.
@JosephMarinier JosephMarinier self-assigned this Mar 21, 2023
@JosephMarinier JosephMarinier marked this pull request as ready for review March 22, 2023 04:02
@JosephMarinier JosephMarinier merged commit 14a954d into main Mar 22, 2023
@JosephMarinier JosephMarinier deleted the joseph/https branch March 22, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants