Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Docker build in two GitHub actions #511

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Separate Docker build in two GitHub actions #511

merged 2 commits into from
Mar 23, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Mar 23, 2023 •
edited
Loading

I didn't test - but I propose that we try directly.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma force-pushed the ggm/separate-docker-build-in-cd branch from d5aa63d to b2a5773 Compare March 23, 2023 00:14
@gabegma gabegma marked this pull request as ready for review March 23, 2023 00:15
JosephMarinier
JosephMarinier approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gabegma gabegma merged commit 2fce7e6 into main Mar 23, 2023
@gabegma gabegma deleted the ggm/separate-docker-build-in-cd branch March 23, 2023 16:56
gabegma added a commit that referenced this pull request Mar 23, 2023
@gabegma @JosephMarinier
Merge main on releases (#513)
b0354c9 
* Update changelog.md

* Separate Docker build in two GitHub actions (#511)

* Separate Docker build in two GitHub actions

* Join two deployment jobs in one workflow

---------

Co-authored-by: joseph.marinier <joseph.marinier@servicenow.com>

---------

Co-authored-by: joseph.marinier <joseph.marinier@servicenow.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosephMarinier JosephMarinier JosephMarinier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gabegma @JosephMarinier