Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update python to 3.9 #534

Merged
merged 4 commits into from
Apr 11, 2023
Merged

Update python to 3.9 #534

merged 4 commits into from
Apr 11, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Apr 9, 2023 •
edited
Loading

Description:

  • This will allow to use functions from python 3.9.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma self-assigned this Apr 9, 2023
JosephMarinier
JosephMarinier approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How exciting! 🥳

@gabegma gabegma merged commit c77f7fa into main Apr 11, 2023
@gabegma gabegma deleted the ggm/update-python-3.9 branch April 11, 2023 18:25
gabegma added a commit that referenced this pull request Apr 19, 2023
@gabegma @JosephMarinier
Update python to 3.9 (#534)
5989fc1 
* Update python to 3.9

* Resolve TODO

* Fix mypy

* Update docs

---------

Co-authored-by: joseph.marinier <joseph.marinier@servicenow.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosephMarinier JosephMarinier JosephMarinier approved these changes

Assignees

@gabegma gabegma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gabegma @JosephMarinier