Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up links from Docker Compose #536

Merged
merged 3 commits into from
Apr 10, 2023
Merged

Clean up links from Docker Compose #536

merged 3 commits into from
Apr 10, 2023

Conversation

JosephMarinier
Copy link
Contributor

Description:

Clean up links from Docker Compose (a deprecated feature) by calling backend directly, instead of host.docker.internal.

Also making two other trivial cleanup commits.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@JosephMarinier JosephMarinier self-assigned this Apr 10, 2023
gabegma
gabegma approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JosephMarinier JosephMarinier enabled auto-merge (squash) April 10, 2023 20:42
@JosephMarinier JosephMarinier merged commit d704c36 into main Apr 10, 2023
@JosephMarinier JosephMarinier deleted the joseph/cleanup-links branch April 10, 2023 20:53
gabegma pushed a commit that referenced this pull request Apr 19, 2023
@JosephMarinier @gabegma
Clean up links from Docker Compose (#536)
41809dd 
* Clean up redundant comment

* Clean up `links` from Docker Compose by calling `backend` directly instead of `host.docker.internal`.

* Clean up indentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabegma gabegma gabegma approved these changes

Assignees

@JosephMarinier JosephMarinier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JosephMarinier @gabegma