Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As I was debugging, I noticed a few problems related to dependencies.
if dependencies is not None
would usually not work sincedependencies
is often an empty list. It wouldsecede()
andrejoin()
potentially for nothing.debug
mode and go through the startup task row per row (slowly), some modules would start without waiting for their dependencies. Somewhat it wasn't causing an issue when running at normal speed, but it's safer to define the tasks instart_up_tasks
so that any dependencies are already defined in the list. I added aTODO
so we can improve this in the future.TODO
.Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-files
at the end.our users.
README
files and our wiki for any big design decisions, if relevant.