Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_tags() method #544

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Fix get_tags() method #544

merged 1 commit into from
Apr 12, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Apr 12, 2023

Description:

  • Major issue that I introduced a while ago: get_tags() could take minutes now to compute on bigger datasets. This will fix a major bug where the app would no longer load on bigger datasets.
  • You can see the profiling before and after.
    logs_before.txt
    logs.txt

Checklist

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma self-assigned this Apr 12, 2023
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Good catch! Thank you very much!

@gabegma gabegma merged commit 652628c into main Apr 12, 2023
@gabegma gabegma deleted the ggm/fix-get-tags branch April 12, 2023 21:45
gabegma added a commit that referenced this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants