Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't block execution when waiting for startup tasks #547

Merged
merged 6 commits into from
Apr 17, 2023

Conversation

JosephMarinier
Copy link
Contributor

@JosephMarinier JosephMarinier commented Apr 14, 2023

Description:

image

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@JosephMarinier JosephMarinier self-assigned this Apr 14, 2023
@gabegma
Copy link
Contributor

gabegma commented Apr 14, 2023

I really like the idea!! However, when I tried, I felt more spammed with logs than before; it prints so quickly that it can be hard to follow, as blocks of logs follow each other and it can be hard to see where it starts and ends. I tried a sleep of 5 seconds, and I think it is easier to follow what is going on. What do you think?

azimuth/startup.py Outdated Show resolved Hide resolved
@JosephMarinier JosephMarinier changed the title Check for startup status a lot more frequently Don't block execution when waiting for startup tasks Apr 14, 2023
and in one multiline log to make sure no logs from other processes get inserted in between.
Copy link
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this - this is great!!! The logs are prettier too. Thanks a lot for tackling this! I learned about threading a bit more.

azimuth/startup.py Outdated Show resolved Hide resolved
azimuth/startup.py Outdated Show resolved Hide resolved
azimuth/startup.py Outdated Show resolved Hide resolved
@JosephMarinier
Copy link
Contributor Author

Cool! Thank you! I learned it too!

@JosephMarinier JosephMarinier merged commit 4eea598 into main Apr 17, 2023
@JosephMarinier JosephMarinier deleted the joseph/startup branch April 17, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants