-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't block execution when waiting for startup tasks #547
Conversation
and log status updates only when there are some changes.
I really like the idea!! However, when I tried, I felt more spammed with logs than before; it prints so quickly that it can be hard to follow, as blocks of logs follow each other and it can be hard to see where it starts and ends. I tried a sleep of 5 seconds, and I think it is easier to follow what is going on. What do you think? |
and in one multiline log to make sure no logs from other processes get inserted in between.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this - this is great!!! The logs are prettier too. Thanks a lot for tackling this! I learned about threading a bit more.
… prevent the app from being terminated.
Cool! Thank you! I learned it too! |
Description:
.done()
twiceChecklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-files
at the end.our users.
README
files and our wiki for any big design decisions, if relevant.