Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an API route to get the config history #560

Merged
merged 2 commits into from
May 4, 2023
Merged

Create an API route to get the config history #560

merged 2 commits into from
May 4, 2023

Conversation

JosephMarinier
Copy link
Contributor

Description:

Create an API route to get the config history along with a hash of each config to differentiate them easily.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@JosephMarinier JosephMarinier self-assigned this May 2, 2023
Base automatically changed from joseph/isort-line-length to main May 2, 2023 15:58
gabegma
gabegma approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Awesome work! Have you considered refactoring the code in load_last_from_config_history to leverage the new method?

azimuth/config.py Outdated Show resolved Hide resolved
azimuth/config.py Show resolved Hide resolved
tests/test_routers/test_config.py Show resolved Hide resolved
gabegma
gabegma reviewed May 3, 2023
View reviewed changes
Copy link
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I forgot to "submit review", my comment was pending.

azimuth/types/general/alias_model.py Outdated Show resolved Hide resolved
@JosephMarinier
Create an API route to get the config history
b364bee 
along with a hash of each config to differentiate them easily.
@JosephMarinier
Make validators private methods
a1d2e9b 
so we are not tempted to call them on the objects (for example with autocomplete in PyCharm)
@JosephMarinier JosephMarinier merged commit 943f3e8 into main May 4, 2023
2 checks passed
@JosephMarinier JosephMarinier deleted the joseph/api-config-history branch May 4, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabegma gabegma gabegma approved these changes

Assignees

@JosephMarinier JosephMarinier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JosephMarinier @gabegma