Support adding/removing pipelines/post-processors #561
Conversation
nandhinibsn
force-pushed
the
nandhini/edit-pipeline-postprocessors
branch
from
fb20640
to
47da309
Compare
…es on pipelinepostprocessor addition
nandhinibsn
force-pushed
the
nandhini/edit-pipeline-postprocessors
branch
from
47da309
to
593cbbf
Compare
…stprocessor is null
webapp/src/pages/Settings.tsx
Outdated
| defaultConfig.pipelines![0].postprocessors | ||
| )?.map((postprocessor, index) => ( | ||
| <React.Fragment key={index}> | ||
| <IconButton |
There was a problem hiding this comment.
Now that you moved the delete button definition up (and use position: "absolute"), if you define a custom metric, the remote field gets in front of the button, making clicking it difficult. The delete button should be defined after (below) the fields. Don't forget to try your changes!
webapp/src/pages/Settings.tsx
Outdated
| alignItems="center" | ||
| > | ||
| {displaySectionTitle("General")} | ||
| <IconButton |
There was a problem hiding this comment.
Would it be possible to position the delete button the same way for the pipelines as it is for the postprocessors? So it's uniform.
There was a problem hiding this comment.
I did some styling on the delete button as per your comment.
I still see a bigger gap around the pipeline delete button than there is around the postprocessor delete button.
|
I did some styling on the delete button as per your comment. Let me know what do you think of it. 
|
so it gets the focus when adding a post-processor
so it is clear that you are not limited to the two proposed options (Thresholding and TemperatureScaling)
JosephMarinier
changed the title
Resolve #
Description:
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-filesat the end.our users.
READMEfiles and our wiki for any big design decisions, if relevant.