Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ggm/clean up conf test #66

Merged
merged 6 commits into from
May 11, 2022
Merged

Ggm/clean up conf test #66

merged 6 commits into from
May 11, 2022

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented May 9, 2022

Description:

  • Clean-up fixtures and and various tests.
  • Fix bug where NO_SMART_TAGS and NO_DATA_ACTIONS were added to the dataset as columns, but the values were never the right ones. This was due because is not in [a for a in ALL_DATA_ACTION_FILTERS if a is not DataAction.no_action] was not working. != works.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.

  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • FRONTEND TYPES. Regenerate the front-ent types if you played with types and routes.
    Run cd webapp && yarn types while the back-end is running.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma changed the base branch from main to dev May 9, 2022 22:04
@gabegma gabegma requested a review from Dref360 May 9, 2022 22:12
tests/utils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Dref360 Dref360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!
Minor comment

tests/test_task_manager.py Outdated Show resolved Hide resolved
@gabegma gabegma requested a review from Dref360 May 10, 2022 21:25
@gabegma
Copy link
Contributor Author

gabegma commented May 10, 2022

I found a bug while making changes to fix the tests. I added it in the description of the PR!

@Dref360
Copy link
Contributor

Dref360 commented May 11, 2022

Ah great!

LGTM

@gabegma gabegma merged commit 207d622 into dev May 11, 2022
@gabegma gabegma deleted the ggm/clean-up-conf-test branch May 11, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants