Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish postprocessing switch #74

Merged
merged 6 commits into from
May 26, 2022

Conversation

JosephMarinier
Copy link
Contributor

@JosephMarinier JosephMarinier commented May 20, 2022

Description:

!hover  hover
image image

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.

  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • FRONTEND TYPES. Regenerate the front-ent types if you played with types and routes.
    Run cd webapp && yarn types while the back-end is running.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

Copy link
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Can we add in the hover something like "This only affects the Exploration Space, and won't affect the smart tags."

Copy link
Collaborator

@christyler3030 christyler3030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with design related comment.

@JosephMarinier JosephMarinier changed the title Joseph/polish postprocessing switch Polish postprocessing switch May 20, 2022
Copy link
Collaborator

@christyler3030 christyler3030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved with one tiny suggestion for text.

Co-authored-by: christyler3030 <46576263+christyler3030@users.noreply.github.com>
@JosephMarinier JosephMarinier enabled auto-merge (squash) May 26, 2022 13:41
@JosephMarinier JosephMarinier merged commit 8f23aaa into dev May 26, 2022
@JosephMarinier JosephMarinier deleted the joseph/polish-postprocessing-switch branch May 26, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants