Update docker images names #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,14 +31,14 @@ build_be: | |||
| docker build \ | |||
| --build-arg DEVICE=$(DEVICE) \ | |||
| --build-arg STAGE=$(STAGE) \ | |||
| -t $(REGISTRY)/$(IMAGE)_$(DEVICE):$(TAG)$(TAG_EXT) \ | |||
| -t $(REGISTRY)/$(IMAGE):$(TAG)_$(DEVICE)$(TAG_EXT) \ | |||
There was a problem hiding this comment.
So we don't tag any image with latest, right? Should we?
There was a problem hiding this comment.
Mmm tensorflow assigns latest to their CPU version, should we?
There was a problem hiding this comment.
So like latest and latest-gpu. That way if you forget to specify a tag you at least get something that works. On the other hand, making it explicit like you did prevents users thinking they are using GPU when they are not. I like both. You choose!
JosephMarinier
approved these changes
May 26, 2022
Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update docker images names
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.
ran
pre-commit run --all-filesat the end.Run
cd webapp && yarn typeswhile the back-end is running.our users.
READMEfiles and our wiki for any big design decisions, if relevant.