fixed missing override for the linq extensions

ServiceStack · Mar 7, 2012 · 7c78318 · 7c78318
1 parent d346813
commit 7c78318
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 8 deletions.
diff --git a/src/ServiceStack.OrmLite.Sqlite32/SqliteOrmLiteDialectProvider.cs b/src/ServiceStack.OrmLite.Sqlite32/SqliteOrmLiteDialectProvider.cs
@@ -130,6 +130,11 @@ public override long GetLastInsertId(IDbCommand dbCmd)
 			return (long)result;
 		}
 
+		public override SqlExpressionVisitor<T> ExpressionVisitor<T>()
+		{
+			return new SqliteExpressionVisitor<T>();
+		}
+
 		public override bool DoesTableExist(IDbCommand dbCmd, string tableName)
 		{
 			var sql = "SELECT COUNT(*) FROM sqlite_master WHERE type='table' AND name = {0}"
@@ -148,6 +153,5 @@ public override string GetColumnDefinition(string fieldName, Type fieldType, boo
 				return ret.Replace(" BIGINT ", " INTEGER ");
 			return ret;
 		}
-
 	}
 }
diff --git a/src/ServiceStack.OrmLite.Sqlite64/SqliteOrmLiteDialectProvider.cs b/src/ServiceStack.OrmLite.Sqlite64/SqliteOrmLiteDialectProvider.cs
@@ -130,6 +130,11 @@ public override long GetLastInsertId(IDbCommand dbCmd)
 			return (long)result;
 		}
 
+		public override SqlExpressionVisitor<T> ExpressionVisitor<T>()
+		{
+			return new SqliteExpressionVisitor<T>();
+		}
+
 		public override bool DoesTableExist(IDbCommand dbCmd, string tableName)
 		{
 			var sql = "SELECT COUNT(*) FROM sqlite_master WHERE type='table' AND name = {0}"
@@ -148,6 +153,5 @@ public override string GetColumnDefinition(string fieldName, Type fieldType, boo
 				return ret.Replace(" BIGINT ", " INTEGER ");
 			return ret;
 		}
-
 	}
 }
diff --git a/src/ServiceStack.OrmLite.sln b/src/ServiceStack.OrmLite.sln
@@ -490,6 +490,7 @@ Global
 		{EAA0F35E-66CD-4B3D-BB17-7CE8EDE83AE7}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{EAA0F35E-66CD-4B3D-BB17-7CE8EDE83AE7}.Release|Any CPU.Build.0 = Release|Any CPU
 		{EAA0F35E-66CD-4B3D-BB17-7CE8EDE83AE7}.Release|Mixed Platforms.ActiveCfg = Release|Any CPU
+		{EAA0F35E-66CD-4B3D-BB17-7CE8EDE83AE7}.Release|Mixed Platforms.Build.0 = Release|Any CPU
 		{EAA0F35E-66CD-4B3D-BB17-7CE8EDE83AE7}.Release|x86.ActiveCfg = Release|Any CPU
 		{EAA0F35E-66CD-4B3D-BB17-7CE8EDE83AE7}.STATIC_ONLY NO_EXPRESSIONS|Any CPU.ActiveCfg = Release|Any CPU
 		{EAA0F35E-66CD-4B3D-BB17-7CE8EDE83AE7}.STATIC_ONLY NO_EXPRESSIONS|Mixed Platforms.ActiveCfg = Release|Any CPU
@@ -841,6 +842,7 @@ Global
 		{E692B423-82E9-46DE-AA80-F4E36A4B4D56}.MonoTouch|x86.ActiveCfg = Release|Any CPU
 		{E692B423-82E9-46DE-AA80-F4E36A4B4D56}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{E692B423-82E9-46DE-AA80-F4E36A4B4D56}.Release|Mixed Platforms.ActiveCfg = Release|Any CPU
+		{E692B423-82E9-46DE-AA80-F4E36A4B4D56}.Release|Mixed Platforms.Build.0 = Release|Any CPU
 		{E692B423-82E9-46DE-AA80-F4E36A4B4D56}.Release|x86.ActiveCfg = Release|Any CPU
 		{E692B423-82E9-46DE-AA80-F4E36A4B4D56}.STATIC_ONLY NO_EXPRESSIONS|Any CPU.ActiveCfg = Release|Any CPU
 		{E692B423-82E9-46DE-AA80-F4E36A4B4D56}.STATIC_ONLY NO_EXPRESSIONS|Mixed Platforms.ActiveCfg = Release|Any CPU

diff --git a/src/ServiceStack.OrmLite/Expressions/ReadExtensions.cs b/src/ServiceStack.OrmLite/Expressions/ReadExtensions.cs
@@ -18,8 +18,8 @@ public static List<T> Select<T>(this IDbCommand dbCmd, Expression<Func<T, bool>>
 			where T : new()
 		{
 			var ev = OrmLiteConfig.DialectProvider.ExpressionVisitor<T>();
-			string sql= ev.Where(predicate).ToSelectStatement();
-			using (var reader = dbCmd.ExecReader(sql.ToString()))
+			string sql = ev.Where(predicate).ToSelectStatement();
+			using (var reader = dbCmd.ExecReader(sql))
 			{
 				return ConvertToList<T>(reader);
 			}
@@ -29,8 +29,8 @@ public static List<T> Select<T>(this IDbCommand dbCmd, Func<SqlExpressionVisitor
 			where T : new()
 		{
 			var ev = OrmLiteConfig.DialectProvider.ExpressionVisitor<T>();
-			string sql= expression(ev).ToSelectStatement();
-			using (var reader = dbCmd.ExecReader(sql.ToString()))
+			string sql = expression(ev).ToSelectStatement();
+			using (var reader = dbCmd.ExecReader(sql))
 			{
 				return ConvertToList<T>(reader);
 			}
@@ -40,8 +40,8 @@ public static List<T> Select<T>(this IDbCommand dbCmd, Func<SqlExpressionVisitor
 		public static List<T> Select<T>(this IDbCommand dbCmd, SqlExpressionVisitor<T> expression)
 			where T : new()
 		{
-			string sql= expression.ToSelectStatement();
-			using (var reader = dbCmd.ExecReader(sql.ToString()))
+			string sql = expression.ToSelectStatement();
+			using (var reader = dbCmd.ExecReader(sql))
 			{
 				return ConvertToList<T>(reader);
 			}

diff --git a/tests/ServiceStack.OrmLite.Sqlite32Tests/UseCase/SimpleUseCase.cs b/tests/ServiceStack.OrmLite.Sqlite32Tests/UseCase/SimpleUseCase.cs
@@ -54,8 +54,10 @@ public void Simple_CRUD_example()
 				dbCmd.Insert(new User { Id = 3, Name = "B", CreatedDate = DateTime.Now });
 
 				var rowsB = dbCmd.Select<User>("Name = {0}", "B");
+				var rowsB1 = dbCmd.Select<User>(user => user.Name == "B");
 
 				Assert.That(rowsB, Has.Count.EqualTo(2));
+				Assert.That(rowsB1, Has.Count.EqualTo(2));
 
 				var rowIds = rowsB.ConvertAll(x => x.Id);
 				Assert.That(rowIds, Is.EquivalentTo(new List<long> { 2, 3 }));