Convert StringBuilder instance to use StringBuilderCache

ServiceStack · Apr 29, 2016 · 2939228 · 2939228
1 parent ed73f0f
commit 2939228
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 10 deletions.
diff --git a/src/ServiceStack.Redis/RedisClient_Admin.cs b/src/ServiceStack.Redis/RedisClient_Admin.cs
@@ -32,7 +32,7 @@ public RedisText GetServerRoleInfo()
 
         public string GetConfig(string configItem)
         {
-            var sb = new StringBuilder();
+            var sb = StringBuilderCache.Allocate();
             var byteArray = base.ConfigGet(configItem);
             const int startAt = 1; //skip repeating config name
             for (var i = startAt; i < byteArray.Length; i++)
@@ -43,7 +43,7 @@ public string GetConfig(string configItem)
 
                 sb.Append(bytes.FromUtf8Bytes());
             }
-            return sb.ToString();
+            return StringBuilderCache.ReturnAndFree(sb);
         }
 
         public void SaveConfig()

diff --git a/src/ServiceStack.Redis/RedisEndpoint.cs b/src/ServiceStack.Redis/RedisEndpoint.cs
@@ -1,7 +1,9 @@
 using System;
 using System.Collections.Generic;
+using System.ComponentModel;
 using System.Text;
 using ServiceStack.IO;
+using ServiceStack.Text;
 
 namespace ServiceStack.Redis
 {
@@ -45,7 +47,7 @@ public RedisEndpoint(string host, int port, string password = null, long db = Re
 
         public override string ToString()
         {
-            var sb = new StringBuilder();
+            var sb = StringBuilderCache.Allocate();
             sb.AppendFormat("{0}:{1}", Host, Port);
 
             var args = new List<string>();
@@ -73,7 +75,7 @@ public override string ToString()
             if (args.Count > 0)
                 sb.Append("?").Append(string.Join("&", args));
 
-            return sb.ToString();
+            return StringBuilderCache.ReturnAndFree(sb);
         }
 
         protected bool Equals(RedisEndpoint other)

diff --git a/src/ServiceStack.Redis/RedisNativeClient_Utils.cs b/src/ServiceStack.Redis/RedisNativeClient_Utils.cs
@@ -203,7 +203,7 @@ public virtual void OnConnected()
 
         protected string ReadLine()
         {
-            var sb = new StringBuilder();
+            var sb = StringBuilderCache.Allocate();
 
             int c;
             while ((c = Bstream.ReadByte()) != -1)
@@ -214,7 +214,7 @@ protected string ReadLine()
                     break;
                 sb.Append((char)c);
             }
-            return sb.ToString();
+            return StringBuilderCache.ReturnAndFree(sb);
         }
 
         public bool HasConnected
@@ -680,7 +680,7 @@ protected void Log(string fmt, params object[] args)
 
         protected void CmdLog(byte[][] args)
         {
-            var sb = new StringBuilder();
+            var sb = StringBuilderCache.Allocate();
             foreach (var arg in args)
             {
                 var strArg = arg.FromUtf8Bytes();
@@ -694,7 +694,7 @@ protected void CmdLog(byte[][] args)
                 if (sb.Length > 100)
                     break;
             }
-            this.lastCommand = sb.ToString();
+            this.lastCommand = StringBuilderCache.ReturnAndFree(sb);
             if (this.lastCommand.Length > 100)
             {
                 this.lastCommand = this.lastCommand.Substring(0, 100) + "...";

diff --git a/src/ServiceStack.Redis/RedisPubSubServer.cs b/src/ServiceStack.Redis/RedisPubSubServer.cs
@@ -3,6 +3,7 @@
 using System.Text;
 using System.Threading;
 using ServiceStack.Logging;
+using ServiceStack.Text;
 
 namespace ServiceStack.Redis
 {
@@ -523,15 +524,15 @@ public string GetStatus()
 
         public string GetStatsDescription()
         {
-            var sb = new StringBuilder();
+            var sb = StringBuilderCache.Allocate();
             sb.AppendLine("===============");
             sb.AppendLine("Current Status: " + GetStatus());
             sb.AppendLine("Times Started: " + Interlocked.CompareExchange(ref timesStarted, 0, 0));
             sb.AppendLine("Num of Errors: " + Interlocked.CompareExchange(ref noOfErrors, 0, 0));
             sb.AppendLine("Num of Continuous Errors: " + Interlocked.CompareExchange(ref noOfContinuousErrors, 0, 0));
             sb.AppendLine("Last ErrorMsg: " + lastExMsg);
             sb.AppendLine("===============");
-            return sb.ToString();
+            return StringBuilderCache.ReturnAndFree(sb);
         }
 
         public virtual void Dispose()