This repository has been archived by the owner on Dec 24, 2022. It is now read-only.
Proper casting to interface instead of unextendable redisClient. #237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a problem extending the RedisClient (we are making a prefixed redis client) because the methods are not virtual
we subclassed it anyways and just overwrote the interface methods. but the problem is that RedisClientManagerCacheClient.cs hard casted it to RedisClient instead of the appropriate interface leaving us with not possibility to overwrite this method. I fixed the usages in this PR.
Could you please merge and create a new Core release of servicestack soon?