Deprecate .NET WebRequest APIs that return an implicit HttpWebRespons…

…e which needs disposing
ServiceStack · Jul 30, 2016 · a4a3749 · a4a3749
1 parent cda8823
commit a4a3749
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/ServiceStack.Client/ServiceClientBase.cs b/src/ServiceStack.Client/ServiceClientBase.cs
@@ -1836,6 +1836,7 @@ public static void PopulateRequestMetadata(this IHasSessionId client, object req
             return to;
         }
 
+        [Obsolete("Use: using (client.Get<HttpWebResponse>(request) { }")]
         public static HttpWebResponse Get(this IRestClient client, object request)
         {
             var c = client as ServiceClientBase;
@@ -1844,6 +1845,7 @@ public static HttpWebResponse Get(this IRestClient client, object request)
             return c.Get(request);
         }
 
+        [Obsolete("Use: using (client.Delete<HttpWebResponse>(request) { }")]
         public static HttpWebResponse Delete(this IRestClient client, object request)
         {
             var c = client as ServiceClientBase;
@@ -1852,6 +1854,7 @@ public static HttpWebResponse Delete(this IRestClient client, object request)
             return c.Delete(request);
         }
 
+        [Obsolete("Use: using (client.Post<HttpWebResponse>(request) { }")]
         public static HttpWebResponse Post(this IRestClient client, object request)
         {
             var c = client as ServiceClientBase;
@@ -1860,6 +1863,7 @@ public static HttpWebResponse Post(this IRestClient client, object request)
             return c.Post(request);
         }
 
+        [Obsolete("Use: using (client.Put<HttpWebResponse>(request) { }")]
         public static HttpWebResponse Put(this IRestClient client, object request)
         {
             var c = client as ServiceClientBase;
@@ -1868,6 +1872,7 @@ public static HttpWebResponse Put(this IRestClient client, object request)
             return c.Put(request);
         }
 
+        [Obsolete("Use: using (client.Patch<HttpWebResponse>(request) { }")]
         public static HttpWebResponse Patch(this IRestClient client, object request)
         {
             var c = client as ServiceClientBase;
@@ -1876,6 +1881,7 @@ public static HttpWebResponse Patch(this IRestClient client, object request)
             return c.Patch(request);
         }
 
+        [Obsolete("Use: using (client.CustomMethod<HttpWebResponse>(httpVerb, request) { }")]
         public static HttpWebResponse CustomMethod(this IRestClient client, string httpVerb, object requestDto)
         {
             var c = client as ServiceClientBase;
@@ -1884,6 +1890,7 @@ public static HttpWebResponse CustomMethod(this IRestClient client, string httpV
             return c.CustomMethod(httpVerb, requestDto);
         }
 
+        [Obsolete("Use: using (client.Head<HttpWebResponse>(request) { }")]
         public static HttpWebResponse Head(this IRestClient client, IReturn requestDto)
         {
             var c = client as ServiceClientBase;
@@ -1892,6 +1899,7 @@ public static HttpWebResponse Head(this IRestClient client, IReturn requestDto)
             return c.Head(requestDto);
         }
 
+        [Obsolete("Use: using (client.Head<HttpWebResponse>(request) { }")]
         public static HttpWebResponse Head(this IRestClient client, object requestDto)
         {
             var c = client as ServiceClientBase;
@@ -1900,6 +1908,7 @@ public static HttpWebResponse Head(this IRestClient client, object requestDto)
             return c.Head(requestDto);
         }
 
+        [Obsolete("Use: using (client.Head<HttpWebResponse>(relativeOrAbsoluteUrl) { }")]
         public static HttpWebResponse Head(this IRestClient client, string relativeOrAbsoluteUrl)
         {
             var c = client as ServiceClientBase;

diff --git a/src/ServiceStack/ServiceStack.Signed.csproj b/src/ServiceStack/ServiceStack.Signed.csproj
@@ -115,6 +115,7 @@
     <Compile Include="ConnectionInfo.cs" />
     <Compile Include="ConnectionInfoAttribute.cs" />
     <Compile Include="CsvRequestLogger.cs" />
+    <Compile Include="CustomRequestFilter.cs" />
     <Compile Include="FluentValidation\Internal\CollectionPropertyRule.cs" />
     <Compile Include="Host\Handlers\StaticContentHandler.cs" />
     <Compile Include="HttpCacheFeature.cs" />