Check each previously run migration before attempting to rerun #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… developers are working on the same shared development environment. Issue relates to the assumption that migration classes would not be deleted. If accidentally done, all previous migrations will attempt to be rerun.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check each previously run migration to avoid the issue where multiple developers are working on the same shared development environment. Issue relates to the assumption that migration classes would not be deleted. If accidentally done, all previous migrations will attempt to be rerun. This was caused by only ever checking the last run migration via the
.Limit(1)at the end of the query.This change selects all rows in
Migrationto check against each knownmigrationTypeto validate if it needs to be rerun or not. Optionally, we could optimize to the lastNmigrations like5as this would be very unlikely to hit the same issue but I guess still possible.Related to raised issue in customer forums