Improve name handling from OpenID 2.0 sources #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When retrieving attributes from an OpenID 2.0 source, names were not being handled well. This change ensures that fullName explicitly uses the first of "http://schema.openid.net/namePerson", WellKnownAttributes.Name.FullName, or WellKnownAttributes.Name.Alias to return a value. Where none of these are present but WellKnownAttributes.Name.First and/or WellKnownAttributes.Name.Last are provided, these will be concatenated to infer a fullName.
mythz
added a commit
that referenced
this pull request
Mar 15, 2013
Improve name handling from OpenID 2.0 sources
|
cool, thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retrieving attributes from an OpenID 2.0 source, names were not
being handled well. This change ensures that fullName explicitly uses
the first of "http://schema.openid.net/namePerson",
WellKnownAttributes.Name.FullName, or WellKnownAttributes.Name.Alias to
return a value. Where none of these are present but
WellKnownAttributes.Name.First and/or WellKnownAttributes.Name.Last are
provided, these will be concatenated to infer a fullName.