Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move app initialization code to a weaver.Main method. #359

Merged
merged 3 commits into from
May 30, 2023
Merged

Move app initialization code to a weaver.Main method. #359

merged 3 commits into from
May 30, 2023

Commits on May 26, 2023

  1. Move app initialization code to a weaver.Main method. 

    Previously, application startup code was wrapped up in a function
passed to weaver.Run. However this made it hard to test startup
code. We now have a `Main` method in `weaver.Main` and place the
startup code in the implementation of this method.

Refactored startup the internal API used by weavertest to separate out
starting the application from running its startup code.
    @ghemawat
    ghemawat committed May 26, 2023
    Configuration menu
    Copy the full SHA
    13dfcc4 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Disallow "weaver.Ref[weaver.Main]" component fields.

    @ghemawat
    ghemawat committed May 30, 2023
    Configuration menu
    Copy the full SHA
    3b8efd4 View commit details
    Browse the repository at this point in the history

  2. Drop TODO and add comment for Main

    @ghemawat
    ghemawat committed May 30, 2023
    Configuration menu
    Copy the full SHA
    76bc2b8 View commit details
    Browse the repository at this point in the history