Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Main; changed weaver.Run to take lambda. #409

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Commits on Jun 21, 2023

  1. Removed Main; changed weaver.Run to take lambda.

    This PR reverts #359. In particular, it removes the main component's
    Main method and changes `weaver.Run` to take a lambda.
    
    We made this change for the following reason. The Main method is run by
    `weaver.Run`, but not by `weavertest.Runner.Test`. We felt this was
    confusing. With the lambda API, it is much clearer what is run. This
    change also unifies the `weaver.Run` and `weavertest.Runner.Test` API.
    Both take a lambda with component arguments.
    
    Right now, the signature of `weaver.Run` is a bit gnarly. I think I can
    simplify it a bit in a future PR to remove PointerToMain at least.
    mwhittaker committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    282f46d View commit details
    Browse the repository at this point in the history