Check the ready status of component before it becomes reachable. #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an situation where the component takes a while to
initialize: previously, we were declaring the component as
activated/healthy even during the pending init, resulting in
subsequent method calls failing.
Thanks to rgrandl@ for debugging the issue.
Other changes:
* Don't add a component to the routing info until it has been
initialized. This fixes the health-checking situation where
one component replica becomes healthy, but we subsequently
send method calls to other replicas which fail.
* Fix go vet in a couple of places.
rgrandl
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an situation where the component takes a while to initialize: previously, we were declaring the component as activated/healthy even during the pending init, resulting in subsequent method calls failing.
Thanks to rgrandl@ for debugging the issue.
Other changes: