Brian/bounds library #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix2feng
reviewed
Apr 20, 2020
| } | ||
|
|
||
| /* ============ Functions ============ */ | ||
| function isValid(Bounds memory _bounds) internal pure returns(bool) { |
There was a problem hiding this comment.
Interesting that this one is memory while the other ones are storage. I wonder if we should have both versions for every function
There was a problem hiding this comment.
We can call the storage one isWithinS or isWithinStorage
There was a problem hiding this comment.
Thinking about it, would it work for these to be memory? I think that when a storage element is passed in as a parameter, its automatically turned to memory.
Also, libraries in general, should aim to be in memory so it can be used by a larger variety of purposes
contracts/lib/BoundsLibrary.sol
Outdated
| @@ -0,0 +1,40 @@ | |||
| /* | |||
| Copyright 2019 Set Labs Inc. | |||
felix2feng
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.