Update logic to prevent potential overflow.

SetProtocol · Apr 29, 2020 · e30298e · e30298e
1 parent afcfa2e
commit e30298e
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/contracts/core/liquidators/utils/LiquidatorUtils.sol b/contracts/core/liquidators/utils/LiquidatorUtils.sol
@@ -86,8 +86,9 @@ library LiquidatorUtils {
             currentSetAllocation.sub(nextSetAllocation) :
             nextSetAllocation.sub(currentSetAllocation);
 
-        // Return rebalance volume by multiplying allocationChange by Set market cap
-        return currentSetValue.mul(_currentSetQuantity).mul(allocationChange).deScale().deScale();
+        // Return rebalance volume by multiplying allocationChange by Set market cap, deScaling to avoid
+        // overflow potential, still have 18 decimals of precision
+        return currentSetValue.mul(_currentSetQuantity).deScale().mul(allocationChange).deScale();
     }
 
     /**