This repository has been archived by the owner on Jan 18, 2023. It is now read-only.
Optimize 0x wrapper, reduce unnecessary slices #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asoong
force-pushed
the
alex/optimize_zero_ex_wrapper
branch
from
43dc288
to
3837afe
Compare
Pull Request Test Coverage Report for Build 1144
💛 - Coveralls |
felix2feng
approved these changes
Aug 9, 2018
| @@ -72,42 +73,65 @@ contract ZeroExExchangeWrapper { | |||
| /* ============ Public Functions ============ */ | |||
|
|
|||
| /** | |||
| * IExchangeWrapper interface delegate method. | |||
| * IExchange interface delegate method. | |||
There was a problem hiding this comment.
I made some changes to call everything IExchangeWrapper vs IExchange. Thought it was clearer
There was a problem hiding this comment.
+1, this file was heavily contested in the rebase so I just went with mine. Will make these changes.
| */ | ||
| function exchange( | ||
| address _taker, | ||
| address _, |
There was a problem hiding this comment.
is _ a good name? Could it ever get conflated with _ in a modifier?
There was a problem hiding this comment.
Pretty standard nomenclature for unused variables, just to be clear now. It will get used when we work in relayer fees.
| * | expirationUnixTimeStampSec | 256 | | ||
| * | salt | 288 | | ||
| * | makerAssetData | 320 | | ||
| * | takerAssetData | 320 | |
| bytes memory orderBody = _ordersData.slice( | ||
| _offset, | ||
| _offset.add(orderLength) | ||
| uint256 takerAssetStart = _header.makerAssetDataLength.add(320); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify 0x order library parsing of order data, reduce number of slices. Saving around 40k gas in the process.