This repository has been archived by the owner on Jan 18, 2023. It is now read-only.
Brian/set token fixes #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1246
💛 - Coveralls |
asoong
approved these changes
Aug 10, 2018
contracts/core/SetToken.sol
Outdated
| @@ -288,9 +291,9 @@ contract SetToken is | |||
| address _tokenAddress | |||
| ) | |||
| view | |||
| internal | |||
| public | |||
There was a problem hiding this comment.
Can we move this out of the internal section? Where else is it being used?
There was a problem hiding this comment.
Also, can these be external instead of public?
There was a problem hiding this comment.
Ahh whoops yeah let me move it. And no we can't because it's used in the constructor so we need to have internal access to it as well.
…ogs to both mint and burn.
bweick
force-pushed
the
brian/set_token_fixes
branch
from
3d7f4ee
to
ef70a88
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.