Skip to content
This repository has been archived by the owner on Jan 18, 2023. It is now read-only.

Added redeemTo to core Issuance. #320

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Added redeemTo to core Issuance. #320

merged 2 commits into from
Dec 14, 2018

Conversation

bweick
Copy link
Contributor

@bweick bweick commented Dec 13, 2018

No description provided.

@coveralls
Copy link

coveralls commented Dec 13, 2018

Pull Request Test Coverage Report for Build 3312

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 3273: 0.0%
Covered Lines: 699
Relevant Lines: 699

💛 - Coveralls

* Redeem Set token and return components to separate address
*
* @param _set Address of the Set
* @param _quantity Number of tokens to redeem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update javadoc with _recipient

@@ -220,6 +220,28 @@ contract CoreIssuance is
);
}

/**
* Redeem Set token and return components to separate address
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of separate maybe specified recipient

@bweick bweick merged commit e99125b into master Dec 14, 2018
@bweick bweick deleted the brian/add_redeem_to branch December 14, 2018 19:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants