This repository has been archived by the owner on Jan 18, 2023. It is now read-only.
RedeemIntoEther: Return excess base Set to the user #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5381
💛 - Coveralls |
bweick
approved these changes
Mar 26, 2019
asoong
reviewed
Mar 26, 2019
| @@ -183,7 +183,7 @@ contract RebalancingSetExchangeIssuanceModule is | |||
| ); | |||
|
|
|||
| // Send excess base Set and ether to the user | |||
| returnExcessFunds(baseSetAddress); | |||
| returnIssuanceExcessFunds(baseSetAddress); | |||
There was a problem hiding this comment.
nit: weird grammar. returnExcessIssuanceFunds
| @@ -661,6 +662,56 @@ contract('RebalancingSetExchangeIssuanceModule', accounts => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('when the implied base Set quantity is greater than the issuance params base Set quantity', async () => { | |||
There was a problem hiding this comment.
why do we call it implied base set quantity? can we be clearer about the explanation here and in the comments?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the check that base Set quantity must be the implied quantity from the rebalancing Set in favor of returning dust to the end user.