This repository has been archived by the owner on Jan 18, 2023. It is now read-only.
Rebalancing exchange issuance post audit improvements #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6195
💛 - Coveralls |
asoong
approved these changes
Aug 19, 2019
| * The TokenFlush contains utility functions to send tokens and base SetTokens from the | ||
| * Vault or Contract to a specified user address | ||
| */ | ||
| contract TokenFlush is |
There was a problem hiding this comment.
Is this meant to be reused elsewhere? It's named like it's general but it seems highly coupled with the system. Would prefer it to be specific here instead if it's only done so we can test the library methods. RebalancingSetExchangeTokenChangeHandler or something
There was a problem hiding this comment.
We previously had it in RebalancingSetIssuance - but I realize that we will be using flushing functions for other modules in the future (e.g. token transformation pipeline). So that's why it's refactored to be generic.
felix2feng
deleted the
felix/rb-exchange-issuance-post-audit-improvements
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.