Skip to content
This repository has been archived by the owner on Jan 18, 2023. It is now read-only.

Add SetToken Constructor Tests #56

Merged
merged 1 commit into from
Jun 17, 2018
Merged

Add SetToken Constructor Tests #56

merged 1 commit into from
Jun 17, 2018

Conversation

inje
Copy link
Contributor

@inje inje commented Jun 16, 2018

Changelog

  • Add tests to setToken.spec.ts for constructor

@inje inje requested review from asoong, felix2feng and a team and removed request for asoong and felix2feng June 16, 2018 05:22
@asoong asoong force-pushed the inje+alex/set_token_create_tests branch from 8407370 to 01e55b8 Compare June 16, 2018 23:10
@coveralls
Copy link

coveralls commented Jun 16, 2018 •
edited

Pull Request Test Coverage Report for Build 262

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.444%
Totals Coverage Status
Change from base Build 253: 0.0%
Covered Lines: 94
Relevant Lines: 100
💛 - Coveralls

justinkchen
justinkchen approved these changes Jun 17, 2018
View reviewed changes
Copy link
Contributor

@justinkchen justinkchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing merge conflicts

justinkchen
justinkchen reviewed Jun 17, 2018
View reviewed changes
test/setToken.spec.ts Outdated
@@ -76,6 +80,174 @@ contract("SetToken", (accounts) => {
ABIDecoder.removeABI(SetToken.abi);
});

describe("#constuctor", async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misspelled constructor

@asoong asoong force-pushed the inje+alex/set_token_create_tests branch from 7a56de3 to 95076ca Compare June 17, 2018 01:16
@asoong asoong force-pushed the inje+alex/set_token_create_tests branch from bc576c0 to bdd3472 Compare June 17, 2018 01:23
@asoong asoong merged commit 983dde7 into master Jun 17, 2018
@asoong asoong deleted the inje+alex/set_token_create_tests branch June 17, 2018 01:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justinkchen justinkchen justinkchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@inje @coveralls @justinkchen @asoong