This repository has been archived by the owner on Jan 18, 2023. It is now read-only.
Rename TwoAssetPriceBounded and reorder inheritance #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix2feng
added a commit
that referenced
this pull request
Jan 9, 2020
* Refactor * FIx * Fix compile * Whats going on * Fix * remove.only * WIP. Added math to calculate bounds of auction. Rough integration in LinearAuction contract. * Changes (#560) * Push tests * [Liquidator] Add 2 component validation (#561) * Validations * Fix formula * Add validate tests * Refactored some logic in the auction bound calculations. Changed auction bound calcs from using derivative to extrapolate auction prices to directly computing auction prices. * Remove .only * Refactored liquidator, pushed oracleWhitelist to bounds calculation files. * Updated tests for refactor. * [Liquidator] Add auction and linearAuction tests (#562) * Fix * uncomment * Push * Fix test * Add check to make sure auction bounds aren't the same. * Refactor * FIx * Fix compile * Whats going on * Fix * remove.only * WIP. Added math to calculate bounds of auction. Rough integration in LinearAuction contract. * Changes (#560) * Push tests * [Liquidator] Add 2 component validation (#561) * Validations * Fix formula * Add validate tests * Refactored some logic in the auction bound calculations. Changed auction bound calcs from using derivative to extrapolate auction prices to directly computing auction prices. * Remove .only * Refactored liquidator, pushed oracleWhitelist to bounds calculation files. * Updated tests for refactor. * [Liquidator] Add auction and linearAuction tests (#562) * Fix * uncomment * Push * Fix test * Add check to make sure auction bounds aren't the same. * Update javadoc and comments for Liquidator refactor. * Remove CommonMath usage from Auction. * Brian/dynamic minimum bid (#564) * Added dynamic minimumBid calculation. Altered some token flow logic to match new minimumBid calc. * Added comments and javadocs. * Add commonMath divCil function (#566) Div-ceil * Moved minimumBid calcs to LinearAuction level. Added ceilDiv function. Removed one assertion. * Fix erring helper. * Bump package. * Remove .only * Fix erring tests due to Mock logic. Co-authored-by: Felix Feng <felix2feng@gmail.com> Co-authored-by: bweick <brian.weickmann@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.