This repository has been archived by the owner on Jan 18, 2023. It is now read-only.
Refactored some logic. Added an event upon initialization. Some varia… #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7568
💛 - Coveralls |
felix2feng
reviewed
Mar 2, 2020
felix2feng
reviewed
Mar 2, 2020
| * @return uint256 Streaming Fee | ||
| * @return uint256 Profit Fee | ||
| */ | ||
| function calculateFees() |
There was a problem hiding this comment.
For more flexibility for any contracts that might inherit this as a base contract, would pass in the setAddress as an argument
|
|
||
| /** | ||
| * Updates fee state after a fee has been accrued. Streaming timestamp is always updated. Profit timestamp | ||
| * is only updated if profit fee is collected. High watermark timestamp is updated if profit fee collected | ||
| * or if a highWatermarkResetFrequency amount of time has passed since last profit fee collection. | ||
| * or if a highWatermarkResetPeriod amount of time has passed since last profit fee collection. | ||
| */ | ||
| function updateFeeState( | ||
| uint256 _streamingFee, |
There was a problem hiding this comment.
Would pass in setAddress here as argument.
felix2feng
approved these changes
Mar 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ble renaming.