This repository has been archived by the owner on Jan 18, 2023. It is now read-only.
Performance Fee Calculator Adjust Fee Fix and Scenario Tests #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8124
💛 - Coveralls |
bweick
reviewed
May 18, 2020
| uint256 rebalancingSetValue = SetUSDValuation.calculateRebalancingSetValue(msg.sender, oracleWhiteList); | ||
|
|
||
| feeState[msg.sender].lastProfitFeeTimestamp = block.timestamp; | ||
| feeState[msg.sender].highWatermark = rebalancingSetValue; |
There was a problem hiding this comment.
This needs to be checked to make sure its higher than the previous high watermark. We don't want to reduce the high watermark by accident
bweick
reviewed
May 19, 2020
| // Thus, we need to reset the high water mark here so that users do not pay for profit fees | ||
| // since inception. | ||
| uint256 rebalancingSetValue = SetUSDValuation.calculateRebalancingSetValue(msg.sender, oracleWhiteList); | ||
| uint256 existingHighwatermark = feeState[msg.sender].highWatermark; |
There was a problem hiding this comment.
Why put this into its own variable?
There was a problem hiding this comment.
Thought it would be more clear
felix2feng
changed the title
felix2feng
force-pushed
the
felix/per-fee-adjust-fee-patch
branch
from
30c8297
to
e9d5ab0
Compare
felix2feng
changed the title
felix2feng
changed the title
bweick
reviewed
May 20, 2020
| * | ||
| * CHANGELOG: | ||
| * - 5/17/2020: Update adjustFee function to update high watermark to prevent unexpected fee actualizations | ||
| * when the profitFee was initially 0 |
There was a problem hiding this comment.
Maybe add a note on the new require as well
bweick
reviewed
May 20, 2020
| @@ -258,6 +262,23 @@ contract PerformanceFeeCalculator is IFeeCalculator { | |||
| } else { | |||
| validateProfitFeePercentage(feePercentage); | |||
|
|
|||
| // IMPORATNT: In the case that a profit fee is initially 0 and is set to a non-zero number, | |||
bweick
reviewed
May 20, 2020
| await blockchain.mineBlockAsync(); | ||
| }); | ||
|
|
||
| describe('and there is a profit', async () => { |
There was a problem hiding this comment.
Think we'd want to test whether the new fee is set here as well
bweick
reviewed
May 20, 2020
| @@ -566,6 +568,109 @@ contract('PerformanceFeeCalculator', accounts => { | |||
| expect(feeState.profitFeePercentage).to.be.bignumber.equal(newFeePercentage); | |||
| }); | |||
|
|
|||
| describe('when the profit fee is initially 0 and a profit is marked', async () => { | |||
There was a problem hiding this comment.
Don't think we need the and a profit is marked phrase here since it tests that and the complementary case below
bweick
approved these changes
May 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.